Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix store Update implementation #31

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix store Update implementation #31

merged 1 commit into from
Nov 9, 2023

Conversation

hardikdr
Copy link
Member

@hardikdr hardikdr commented Nov 9, 2023 •
edited by lukasfrank
Loading

Proposed Changes

Avoid updating the Store object if both old and new objects are exactly the same.

Fixes #29

@github-actions github-actions bot added the bug Something isn't working label Nov 9, 2023
@hardikdr hardikdr linked an issue Nov 9, 2023 that may be closed by this pull request
Machine object triggers indefinite reconciliation #29
Closed
@lukasfrank lukasfrank merged commit ca0aaea into main Nov 9, 2023
7 checks passed
@lukasfrank lukasfrank deleted the fix_update_call branch November 9, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Machine object triggers indefinite reconciliation
2 participants
@hardikdr @lukasfrank